[MNG-8535] Full std stream support for executor #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
reviewed
Feb 3, 2025
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Feb 3, 2025
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Feb 3, 2025
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Feb 3, 2025
...maven-executor/src/main/java/org/apache/maven/cling/executor/forked/ForkedMavenExecutor.java
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Feb 3, 2025
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java
Outdated
Show resolved
Hide resolved
patrickkenya
approved these changes
Feb 5, 2025
cstamas
force-pushed
the
MNG-8535
branch
4 times, most recently
from
a5af3cc to
ddcbeca
Compare
The std stream support was incomplete in maven-executor --- https://issues.apache.org/jira/browse/MNG-8535
This reverts commit 31e418f.
To prevent misleading problem of embedded executor trying to load up same native library over and over again. The use case of EmbeddedExecutor is anyway to create it and keep it alive as long needed (see ITs).
Load classloader once, not per command.
This reverts commit ac509bf.
gnodet
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The std stream support was incomplete in maven-executor
https://issues.apache.org/jira/browse/MNG-8535